Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add doctl #37

Merged
merged 36 commits into from
Dec 13, 2021
Merged

feat: add doctl #37

merged 36 commits into from
Dec 13, 2021

Conversation

marceloavf
Copy link
Owner

@marceloavf marceloavf commented Nov 26, 2021 •
edited
Loading

Description

Add Doctl installer and command handler

Review

Installer

  • Tests
  • Install the latest version
  • Check if latest version exist before installing

Command

  • Tests
  • Base parameters

Others

  • Docs usage for README and Azure Devops Docs
  • Check for information in build time for download and upload
  • Debounce data log for downloading a file (too much information)
  • Create a marketing image, share on twitter and tag digitalocean, azure devops, microsoft
  • Allow minimum 70% coverage
  • Add all-contributors - https://github.com/all-contributors/all-contributors

https://github.com/marceloavf/digitalocean-tools-vsts/blob/doctl/Tasks/DigitalOceanSpacesDownload/utils/Download.ts#L145

@codecov
Copy link

codecov bot commented Nov 26, 2021 •
edited
Loading

Codecov Report

Merging #37 (ebbea7e) into master (4629088) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            master       #37    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files           18        26     +8     
  Lines          258       365   +107     
  Branches        19        33    +14     
==========================================
+ Hits           258       365   +107
Impacted Files Coverage Δ
Tasks/DigitalOceanDoctl/digitalOceanDoctl.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanDoctl/index.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanDoctl/tl.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanDoctl/utils/Doctl.ts 100.00% <100.00%> (ø)
...lOceanDoctlInstaller/digitalOceanDoctlInstaller.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanDoctlInstaller/index.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanDoctlInstaller/tl.ts 100.00% <100.00%> (ø)
...asks/DigitalOceanDoctlInstaller/utils/Installer.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDelete/tl.ts 100.00% <100.00%> (ø)
Tasks/DigitalOceanSpacesDelete/utils/Delete.ts 100.00% <100.00%> (ø)
... and 12 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4629088...ebbea7e. Read the comment docs.

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@marceloavf marceloavf merged commit 3add6cf into master Dec 13, 2021
@marceloavf marceloavf deleted the doctl branch December 13, 2021 14:49
marceloavf pushed a commit that referenced this pull request Dec 13, 2021
@semantic-release-bot
chore(release): 2.0.0 [skip ci] ***NO_CI***
f7c2cfd 
# [2.0.0](v1.0.0...v2.0.0) (2021-12-13)

### Features

* add doctl ([#37](#37)) ([3add6cf](3add6cf))

### BREAKING CHANGES

* Many packages have been updated to major versions
@marceloavf
Copy link
Owner Author

🎉 This PR is included in version 2.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@marceloavf marceloavf added the released This is ready to use! label Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released This is ready to use!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@marceloavf